We have one of these. It contains smell well enough but the kid sometimes knocks it over and the top opens (where you put a bag in) very easily when it isn’t upright.
We had one of these with kid 1 and it worked well enough. Replacement bags were a bit annoying to get in place or put back in place if kids messed with it, but smell was pretty decent. I got tired of wasting some of the bags just by tying knots, so I recommend just getting a bag of small zip ties and using two for the bottom and one on top. Those inches of saved plastic helps you squeak out an extra back or two, and it’s way easier to tie off.